afs commented on code in PR #2888:
URL: https://github.com/apache/jena/pull/2888#discussion_r1876827605
##########
jena-core/src/main/java/org/apache/jena/irix/IRIProviderJenaIRI.java:
##########
Review Comment:
Use switch form that does not need "break" - clearer that "continue" is the
loop.
##########
jena-core/src/main/java/org/apache/jena/irix/SetupJenaIRI.java:
##########
@@ -99,9 +99,11 @@ public static IRIFactory iriCheckerFactory() {
setErrorWarning(iriCheckerFactory,
ViolationCodes.NON_INITIAL_DOT_SEGMENT, false, false);
// == Character related.
- //setErrorWarning(iriFactoryInst, ViolationCodes.NOT_NFC, false,
false);
+ // Causes confusion! And this is only advice in RDF Concepts.
+ setErrorWarning(iriCheckerFactory, ViolationCodes.NOT_NFC, false,
false);
Review Comment:
This is THE change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org
