afs commented on code in PR #2925:
URL: https://github.com/apache/jena/pull/2925#discussion_r1916747478
##########
jena-arq/src/main/java/org/apache/jena/sparql/engine/iterator/QueryIterLateral.java:
##########
@@ -292,17 +295,33 @@ public Op transform(OpTable opTable) {
// By the assignment restriction, the binding only needs to be
added to each row of the table.
Table table = opTable.getTable();
// Table vars.
- List<Var> vars = new ArrayList<>(table.getVars());
- binding.vars().forEachRemaining(vars::add);
- TableN table2 = new TableN(vars);
+ List<Var> tableVars = table.getVars();
+ List<Var> vars = new ArrayList<>(tableVars);
+
+ // Track variables that appear both in the table and the binding.
+ List<Var> commonVars = new ArrayList<>();
+
+ // Index variables in a set if there are more than a few of them.
+ Collection<Var> tableVarsIndex = tableVars.size() > 4 ? new
HashSet<>(tableVars) : tableVars;
+ binding.vars().forEachRemaining(v -> {
+ if (tableVarsIndex.contains(v)) {
Review Comment:
The table vars can't contain a binding var (or am I missing something?).
That case is caught by the text
https://github.com/w3c/sparql-dev/blob/main/SEP/SEP-0007/sep-0007.md
"Disallow syntactic forms that set variables that may already be present in
the current row."
It's tested in `SyntaxVarScope.checkLATEAL`.
(I removed the `if`, left the `else` and the two tests pass.)
If so, it simplifies to `vars.add(v);`
And hence "vars = tableVars" (copy not needed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org
