afs commented on code in PR #3019:
URL: https://github.com/apache/jena/pull/3019#discussion_r1960624945


##########
jena-shacl/src/test/files/std/core/property/uniqueLang-001.ttl:
##########


Review Comment:
   There's a problem with this test because the validation report entry is 
about the first failure - the second node encountered with the same language 
tag. But there is no definite order from the "I", or "Me" nodes being tested 
and that means different validation report entries
   
   I get about 50% failures on github CI.
   
   I'm not sure what to do about this. In the test runner, there is way to 
choose which properties to test of equivalent of validation reports and that 
includes sh:values but that is useful in other cases.
   
   NB `files/std/core/*` are direct copies from the SHACL test suite.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org

Reply via email to