Aklakan commented on PR #3027:
URL: https://github.com/apache/jena/pull/3027#issuecomment-2912673872
I completed the final changes (currently part of the second commit):
- Renamed `SpatialIndexUtils` to `SpatialIndexLib`
- Moved symbols to `SpatialIndexConstants` (akin to `ARQConstants`)
- Fixed a bug where server side events (SSE) about index/clean tasks were
sent to listeners across all endpoints
- All task logic is now disentangled from the servlet and resides in
SpatialIndexLib. A `TaskListener` indirection is used to advertise task life
cycle state changes (e.g. running, aborting) as SSE events. I still think this
can be improved but it is much better than before.
- Disabled auto-registration of spatial indexer endpoints for sparql update
endpoints. Due to security concerns I think its better and more idiomatic to
require a usual Fuseki endpoint declaration as below.
- Added additional tests for index updates, including the case when access
is restricted to a subset of the available graphs. I only then learned that
Fuseki denies modding endpoints for graph based access controlled datasets. The
spatial indexer implementation would be ready for it.
- Added warnings if SRS and/or spatial index file location are not
configured in the assembler.
- Cleaned up logging out
This config snippet needs to be documented:
```turtle
<#ep-si> fuseki:name "spatial-indexer" ;
fuseki:operation fuseki:spatial-indexer ;
fuseki:allowedUsers "test" . # Optional access control.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org
