afs commented on code in PR #3245: URL: https://github.com/apache/jena/pull/3245#discussion_r2136051185
########## jena-core/src/main/java/org/apache/jena/mem2/iterator/SparseArrayIndexedIterator.java: ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.jena.mem2.iterator; + +import org.apache.jena.mem2.collection.FastHashSet; +import org.apache.jena.util.iterator.NiceIterator; + +import java.util.Iterator; +import java.util.NoSuchElementException; +import java.util.function.Consumer; + +/** + * An iterator over a sparse array, that skips null entries. + * This iterator returns elements as {@link FastHashSet.IndexedKey} objects, + * which contain both the index and the value of the element. + * + * The iterator works in ascending order, starting from index 0 up to the specified exclusive index. + * + * This iterator will check for concurrent modifications by invoking a {@link Runnable} + * + * @param <E> the type of the array elements + */ +public class SparseArrayIndexedIterator<E> extends NiceIterator<FastHashSet.IndexedKey<E>> implements Iterator<FastHashSet.IndexedKey<E>> { Review Comment: ```suggestion @SuppressWarnings("javadoc") public class SparseArrayIndexedIterator<E> extends NiceIterator<FastHashSet.IndexedKey<E>> implements Iterator<FastHashSet.IndexedKey<E>> { ``` This shows up as a Eclipse (latest) warning. I had to add @SuppressWarnings("javadoc") to the class to suppress it. ########## jena-core/src/main/java/org/apache/jena/mem2/spliterator/SparseArrayIndexedSpliterator.java: ########## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.jena.mem2.spliterator; + +import org.apache.jena.mem2.collection.FastHashSet; + +import java.util.Spliterator; +import java.util.function.Consumer; + +/** + * A spliterator for sparse arrays. This spliterator will iterate over the array + * skipping null entries. + * This spliterator returns elements as {@link FastHashSet.IndexedKey} objects, + * which contain both the index and the value of the element. + * <p> + * This spliterator works in ascending order, starting from the given start up to the specified exclusive index. + * <p> + * This spliterator supports splitting into sub-spliterators. + * <p> + * The spliterator will check for concurrent modifications by invoking a {@link Runnable} + * before each action. + * + * @param <E> the type of the array elements + */ +public class SparseArrayIndexedSpliterator<E> implements Spliterator<FastHashSet.IndexedKey<E>> { Review Comment: ```suggestion @SuppressWarnings("javadoc") public class SparseArrayIndexedSpliterator<E> implements Spliterator<FastHashSet.IndexedKey<E>> { ``` Same as before. This shows up as a Eclipse (latest) warning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org For additional commands, e-mail: pr-h...@jena.apache.org
