rvesse opened a new pull request, #3274:
URL: https://github.com/apache/jena/pull/3274

   This commit adds the ability for `ParameterizedSparqlString` to support 
injecting the `UNDEF` keyword into `VALUES` clauses as needed.  A new `undef()` 
method is added to the class that provides access to a special instance level 
constant `RDFNode` that is used to indicate that the caller wants to inject 
`UNDEF`.
   
   Under the hood this is just a wrapper around a `Node` constant but due to 
the `setValues()`/`setRowValues()` part of the API working in `RDFNode`'s 
rather than `Node`'s went with this approach.  I considered refactoring further 
to allow that part of the API to take `Node` and `RDFNode` interchangeably 
**but** given the limitations of Java type erasure generics (several of the 
methods in that part of the API use `Collection<? extends RDFNode>` and 
similar) that would effectively introduce a breaking API change so probably 
best done for a major release in a separate PR.
   
   GitHub issue resolved #3268 
   ----
   
    - [x] Tests are included.
    - [ ] Documentation change and updates are provided for the [Apache Jena 
website](https://github.com/apache/jena-site/)
    - [x] Commits have been squashed to remove intermediate development commit 
messages.
    - [x] Key commit messages start with the issue number (GH-xxxx)
   
   By submitting this pull request, I acknowledge that I am making a 
contribution to the Apache Software Foundation under the terms and conditions 
of the [Contributor's 
Agreement](https://www.apache.org/licenses/contributor-agreements.html).
   
   ----
   
   See the [Apache Jena "Contributing" 
guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org

Reply via email to