kinow commented on code in PR #2789:
URL: https://github.com/apache/jena/pull/2789#discussion_r2173514958
##########
jena-fuseki2/jena-fuseki-ui/src/views/dataset/Edit.vue:
##########
@@ -218,9 +244,9 @@ export default {
services (newVal) {
if (newVal && newVal['gsp-rw'] && Object.keys(newVal['gsp-rw']).length >
0) {
const element = this.$refs['graph-editor']
- this.codemirrorEditor = CodeMirror.fromTextArea(element,
this.cmOptions)
- this.codemirrorEditor.on('change', cm => {
- this.content = cm.getValue()
+ this.codemirrorEditor = editorFromTextArea(element,
this.cmOptions.extensions)
+ EditorView.updateListener.of(v => {
Review Comment:
This was tough to understand how to fix. There was nothing in the docs of
CodeMirror for migrating the code, no issues or anything obvious on their GH
issue.
Luckily, found an example in CodeMirror forums for that:
https://discuss.codemirror.net/t/listen-to-change-event/5095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org
