Aklakan commented on code in PR #3184:
URL: https://github.com/apache/jena/pull/3184#discussion_r2334546086


##########
jena-arq/src/main/java/org/apache/jena/sparql/modify/UpdateProcessorBase.java:
##########
@@ -70,6 +71,17 @@ public UpdateProcessorBase(UpdateRequest request,
         }
     }
 
+    @Override
+    public UpdateRequest getUpdateRequest() {
+        // XXX Return a copy for safety?

Review Comment:
   Decided on returning the update request as-is because 
`QueryExecDataset.getQuery()` also just returns the internal query object. 
Builders that produce immutable Query/UpdateRequest objects may be a future 
enhancement.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org

Reply via email to