Aklakan commented on code in PR #3441:
URL: https://github.com/apache/jena/pull/3441#discussion_r2350334586
##########
jena-rdfconnection/src/main/java/org/apache/jena/rdflink/RDFLinkHTTP.java:
##########
@@ -316,53 +312,54 @@ protected void setQuery(Query query, String queryStr) {
queryType = query == null ? QueryType.UNKNOWN : query.queryType();
}
+ /**
+ * For parsed queries: Derive and return the appropriate accept header.
+ * For non-parsed queries: This method returns null. The header is
then chosen
+ * based on the used method of the query exec. For example,
+ * {@link QueryExecHTTP#select()} will use the configured select
header.
+ */
+ private String deriveAcceptHeaderFromQueryType() {
Review Comment:
I think this method can new be removed: QueryExecHTTP now knows all headers
and can choose among the configured ones when `QueryExecHTTP.[queryType]` is
called.
##########
jena-rdfconnection/src/main/java/org/apache/jena/rdflink/RDFLinkHTTP.java:
##########
@@ -316,53 +312,54 @@ protected void setQuery(Query query, String queryStr) {
queryType = query == null ? QueryType.UNKNOWN : query.queryType();
}
+ /**
+ * For parsed queries: Derive and return the appropriate accept header.
+ * For non-parsed queries: This method returns null. The header is
then chosen
+ * based on the used method of the query exec. For example,
+ * {@link QueryExecHTTP#select()} will use the configured select
header.
+ */
+ private String deriveAcceptHeaderFromQueryType() {
Review Comment:
I think this method can now be removed: QueryExecHTTP now knows all headers
and can choose among the configured ones when `QueryExecHTTP.[queryType]` is
called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org
