afs commented on code in PR #3517:
URL: https://github.com/apache/jena/pull/3517#discussion_r2441274279
##########
jena-arq/src/test/java/org/apache/jena/sparql/engine/join/TestHashJoin.java:
##########
@@ -19,12 +19,27 @@
package org.apache.jena.sparql.engine.join;
import org.apache.jena.sparql.algebra.Table;
+import org.apache.jena.sparql.engine.ExecutionContext;
import org.apache.jena.sparql.engine.QueryIterator;
+import org.apache.jena.sparql.engine.binding.BindingFactory;
+import org.apache.jena.sparql.engine.iterator.QueryIter;
+import org.apache.jena.sparql.engine.iterator.QueryIterSingleton;
import org.apache.jena.sparql.expr.ExprList;
+import org.apache.jena.sparql.util.Context;
+import org.junit.jupiter.api.Test;
public class TestHashJoin extends AbstractTestInnerJoin {
@Override
public QueryIterator join(JoinKey joinKey, Table left, Table right,
ExprList conditions) {
return Join.hashJoin(joinKey, left.iterator(null),
right.iterator(null), null);
}
+
+ @Test
+ public void testCloseOfUnusedIterator() {
Review Comment:
Can this be pushed up into `AbstractTestInnerJoin`?
It need to call `join(joinKey,...)` or have a new abstract method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
