afs commented on code in PR #3480:
URL: https://github.com/apache/jena/pull/3480#discussion_r2404551531
##########
jena-arq/src/main/java/org/apache/jena/rdfs/DatasetGraphRDFS.java:
##########
@@ -67,6 +67,10 @@ public Graph getGraph(Node graphNode) {
return new GraphRDFS(base, setup);
}
+ @Override
Review Comment:
As I read the code on main:
`find()` ->
`find()` in DatasetGraphWrapper ->
default method DatasetGraph.find() ->
find(Node.ANY, Node.ANY, Node.ANY, Node.ANY);
so this is not necessary.
And `Node.ANY` is better than null :smile:
##########
jena-arq/src/main/java/org/apache/jena/sparql/util/Context.java:
##########
@@ -439,13 +434,36 @@ public static AtomicBoolean getCancelSignal(Context
context) {
}
}
+ /** Atomic compute. */
Review Comment:
Haven't I seen these Context changes in another of your PRs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
