Aklakan commented on code in PR #3511: URL: https://github.com/apache/jena/pull/3511#discussion_r2603677028
########## jena-arq/src/main/java/org/apache/jena/sparql/adapter/SparqlAdapter.java: ########## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.jena.sparql.adapter; + +import org.apache.jena.sparql.exec.QueryExecBuilder; +import org.apache.jena.sparql.exec.UpdateExecBuilder; + +public interface SparqlAdapter { + QueryExecBuilder newQuery(); Review Comment: I don't think that I am mixing orthogonal concerns - but I am open to criticism. To recap: * SparqlAdapterProvider provides a "SPARQL layer" implementation for a dataset graph implementation. * A SPARQL layer implementation comprises builders for query, update and GSP requests. * `DatasetGraphOverRDFLink` is a specific `DatasetGraph` implementation backed by a factory of RDFLinks. Much like a JDBC data source is a factory for connections. * `SparqlAdapterProviderDatasetGraphOverRDFLink` is the adapter for `DatasetGraphOverRDFLink`. For example, when querying, this provider will supply specialized `QueryExecBuilderOverRDFLink` instances that will pass on a query statement to the link - instead of evaluating it against the dataset graph API. Note, that the sparql adapter system of this PR works under the hood - conventional code should never have to interact with it directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
