OyvindLGjesdal commented on PR #3778: URL: https://github.com/apache/jena/pull/3778#issuecomment-3986140373
Three depencies are not updated for 10 yet and gives warnings: ``` [email protected]" has incorrect peer dependency "eslint@^9.10.0". warning "@vue/eslint-config-standard > [email protected]" has incorrect peer dependency "eslint@^8.57.0 || ^9.0.0". warning " > [email protected]" has incorrect peer dependency "eslint@^7.0.0 || ^8.0.0 || ^9.0.0". warning " > eslint-plugin-import ``` After update there are also some new lint errors: ``` $ eslint --fix src /Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/components/ServerStatus.vue 66:21 error 'setInterval' is not defined no-undef 72:5 error 'clearInterval' is not defined no-undef /Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/components/Toast.vue 120:7 error 'setTimeout' is not defined no-undef /Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/plugins/services.js 26:67 error 'window' is not defined no-undef /Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/services/fuseki.service.js 147:13 error There is no `cause` attached to the symptom error being thrown preserve-caught-error 149:11 error There is no `cause` attached to the symptom error being thrown preserve-caught-error /Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/services/mock/json-server.js 290:7 error 'console' is not defined no-undef 299:3 error 'console' is not defined no-undef /Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/utils/query.js 43:5 error 'document' is not defined no-undef 45:5 error 'document' is not defined no-undef 46:5 error 'document' is not defined no-undef 47:5 error 'document' is not defined no-undef /Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/utils/validation.js 42:9 error 'URL' is not defined no-undef /Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/views/dataset/Edit.vue 245:9 error 'alert' is not defined no-undef /Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/views/dataset/Query.vue 274:7 error 'setTimeout' is not defined no-undef 277:9 error 'document' is not defined no-undef 278:9 error 'document' is not defined no-undef 282:11 error 'document' is not defined no-undef 299:11 error 'document' is not defined no-undef /Users/oyvindlgjesdal/repos/apache/jena/jena-fuseki2/jena-fuseki-ui/src/views/manage/Tasks.vue 117:20 error 'setInterval' is not defined no-undef 130:7 error 'clearInterval' is not defined no-undef ``` Since jena has implemented/moved into the flat config file described in https://eslint.org/docs/latest/use/configure/migration-guide I think the old style rc files are not read. Therefore I think these are currently not used/picked up: ``` ./tests/.eslintrc.js ./tests/e2e/.eslintrc.js ``` and have to be migrated to the flat format (`eslint.config.js` in `jena-fuseki-ui`). However the ci job that runs lint also just uses `eslint --fix src` so I think that means the linting for tests has mostly been done on the developer machine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
