OyvindLGjesdal commented on PR #3976: URL: https://github.com/apache/jena/pull/3976#issuecomment-4650248735
I looked at this (with an LLM) and did some tests on what was minimal to pass the tests, and I think using the query, together with the path, while also setting the algorithm is enough to make the tests pass. Note that sometimes it seemed to intermittently fail also. See https://github.com/apache/jena/compare/main...OyvindLGjesdal:jena:dependabot/maven/maven-patch-group-52fd5e174b Not very confident here with the code and me understanding the full context. I ran ``` # local files in path, so skipping rat mvn -DskipTests install -pl jena-integration-tests -am -Drat.skip=true mvn test -pl jena-integration-tests -Dsurefire.rerunFailingTestsCount=5 ``` The LLM also suggested changing the starting value for the nonce to 1 (as per the RFC) as well as adding a header, but those didn't fix or change the failing tests (commented them out, rebuilt and reran tests successfully). I guess a proper long term fix would be to change the implementation to use a recommended algorithm? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
