ThomasThelen opened a new pull request, #4016: URL: https://github.com/apache/jena/pull/4016
GitHub issue resolved #3320 Pull request Description: This PR supports computing distance with linear units. To do this we make use of the great circle... [DistanceFF.java](https://github.com/apache/jena/compare/main...ThomasThelen:jena:issue_3320?expand=1#diff-ee2b69cbd13171218d2817f079b37aa43b65fb27e7e7a93540a6153b247bfbc9) currently hardcodes the distance to be Euclidean however, the generic [distance](https://github.com/apache/jena/blob/bd2d36dfdb06dca5b3249866c4e844a98d1db450/jena-geosparql/src/main/java/org/apache/jena/geosparql/implementation/GeometryWrapper.java#L656) method already has routing to select the appropriate distance function (as per the reporting ticket). The comment on the changed line refers to geosparql 1.0 _only supporting euclidean distances_! With Geosparql 1.1 we can now support others so I believe this change is in line with the spec. ---- - [ ] Tests are included. - [ ] Documentation change and updates are provided for the [Apache Jena website](https://github.com/apache/jena-site/) - [ ] Commits have been squashed to remove intermediate development commit messages. - [ ] Key commit messages start with the issue number (GH-xxxx) By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html). ---- See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
