ThomasThelen opened a new pull request, #4022:
URL: https://github.com/apache/jena/pull/4022
GitHub issue resolved #1361
Pull request Description:
#1361 mentions a bug where the filtered function flag wasn't being respected
when backward chaining. The author fortunately outlined the places in the
forward chaining path where it's respected - so adding them to the backward
path was fairly straight forward. _This shouldn't have any weird side effects_
but I haven't used the reasoner with custom filters before (was a cool
exploration).
In terms of testing I added a unit test that checks the filter
present/absent based on the new boolean flag. If you'd like this unit test to
be split into two, just let me know and I'll push another commit with the
changes.
----
- [ ] Tests are included.
- [ ] Documentation change and updates are provided for the [Apache Jena
website](https://github.com/apache/jena-site/)
- [ ] Commits have been squashed to remove intermediate development commit
messages.
- [ ] Key commit messages start with the issue number (GH-xxxx)
By submitting this pull request, I acknowledge that I am making a
contribution to the Apache Software Foundation under the terms and conditions
of the [Contributor's
Agreement](https://www.apache.org/licenses/contributor-agreements.html).
----
See the [Apache Jena "Contributing"
guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
