Aklakan commented on PR #3995:
URL: https://github.com/apache/jena/pull/3995#issuecomment-4826894108
The code is ready for review.
* The most critical changes to existing code are those in
`BPTreeDistinctKeyPrefixIterator` which are meant to restrict skip scans /
index scans to custom sub-ranges.
\
When no custom range is specified, then the range used to be
`bptRootNode.{minRecord, maxRecord}`, which indicates that maxRecord is
inclusive for page-lever iteration. However, when doing record-level interation
using `records.getRecordBuffer().iterator(minRecord, maxRecord)` then maxRecord
is exclusive. So this is something @rvesse and/or @afs might want to look at
whether this is correct and how it should be.
* The class ``TestOpExecutorTDB2SkipScan` generates `SELECT DISTINCT ...`
and `SELECT ... (COUNT(DISTINCT ?v) AS ?c) { ... } GROUP BY ...` queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
