ThomasThelen opened a new pull request, #4032:
URL: https://github.com/apache/jena/pull/4032

   GitHub issue resolved #1868
   
   Pull request Description:
   
   This is a bit of an experimental path taken. Initially I had done this with 
a longer walking of the AST and realized that the performance hit would be too 
big because `evalGroundedPath` gets called on each binding.
   
   Instead, the approach that I took here is to hardcode the zero length 
component state as part of the various path classes, culminating in the 
dispatch to 
[evalGroundedPath](https://github.com/apache/jena/compare/main...ThomasThelen:jena:issue_1868?expand=1#diff-ae05f150796221eeb88c0c8bd337eec22ced6a1cff4c2d28e2f80d1509ab2305R135).
 This should get called _once_ rather than the _n_ times for each row in my 
previous AST implementation. 
   
   Happy to provide performance tests, address feedback, or close this if it's 
a bit far fetched.
   
   ----
   
    - [ ] Tests are included.
    - [ ] Documentation change and updates are provided for the [Apache Jena 
website](https://github.com/apache/jena-site/)
    - [ ] Commits have been squashed to remove intermediate development commit 
messages.
    - [ ] Key commit messages start with the issue number (GH-xxxx)
   
   By submitting this pull request, I acknowledge that I am making a 
contribution to the Apache Software Foundation under the terms and conditions 
of the [Contributor's 
Agreement](https://www.apache.org/licenses/contributor-agreements.html).
   
   ----
   
   See the [Apache Jena "Contributing" 
guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to