ThomasThelen opened a new pull request, #4054:
URL: https://github.com/apache/jena/pull/4054

   GitHub issue resolved #1998 
   
   Pull request Description:
   
   This PR addresses the issue by going with @osma's proposed solution at the 
end of the issue thread. The only tricky part was including the locale 
information, but luckily the folks in the issue thread pinpointed how to do 
this. The gist is that `jdk.localedata` is now explicitly put in the jlink 
module list.
   
   The main concern here is image size _because the default behavior is to 
include all locales_.
   
   Here are two image builds: the first being the default case of including all 
locales vs he second which only has english.
   ```
        Name                                                              Disk 
Usage                   Image Size
   fuseki:5.3.0-all                                   997c0b2b9c4f        318MB 
                         140MB
   fuseki:5.3.0-en                                    14718521a9b4        297MB 
                         130MB
   ```
   
   ----
   
    - [ ] Tests are included.
    - [ ] Documentation change and updates are provided for the [Apache Jena 
website](https://github.com/apache/jena-site/)
    - [ ] Commits have been squashed to remove intermediate development commit 
messages.
    - [ ] Key commit messages start with the issue number (GH-xxxx)
   
   By submitting this pull request, I acknowledge that I am making a 
contribution to the Apache Software Foundation under the terms and conditions 
of the [Contributor's 
Agreement](https://www.apache.org/licenses/contributor-agreements.html).
   
   ----
   
   See the [Apache Jena "Contributing" 
guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to