> I'm curious, what made you decide to calculate the derived properties
> on prepare instead of precomputing them? Have you done any
> benchmarking of this? I'd love to see the performance difference
> between this way and pre-computing a big trie or something of derived
> properties.

Thanks for your review and suggestion!
I am not sure what you mean by "pre-computing them“. Most of these derived 
properties (methods) are based on the java.lang.Character class and are 
similarly designed as e.g. Character.isDigit(int cp).
If you mean having a huge code point table, like in your tables.go file: I 
think Java already has such tables internally.
What could be improved here, is that Character.getType(cp) could only be 
invoked once. I haven’t done any benchmark for this, but I don’t expect a 
significant performance benefit.

— Christian
_______________________________________________
precis mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/precis

Reply via email to