On 6/18/07, Kohsuke Ohtani <[EMAIL PROTECTED]> wrote:
>
> I applied following patches.
> Thank you.
Hi Kohsuke,
I'm happy to contribute where I can.
Are you going to apply the driver related patches (16, 17, 18, 20,
21)? Please discuss any issues you have that are stopping you applying
some or all of these changes.
>
> [Prex-devel] [PATCH 04/22] allow global platform specific flags
> =>Platform dependent definition should be defined in
> arch/$(ARCH)/Makefile.$(PLATFORM) if it's needed.
Ok - so you have just renamed the include target I added in
{boot,sys,dev}.mk to be consistent with task.mk
> [Prex-devel] [PATCH 08/22] ioctl command decoding macros - useful for
> drivers
> =>I preffer the following definitions as same with *BSD.
> #define IOCPARM_LEN(x) (((x) >> 16) & IOCPARM_MASK)
> #define IOCBASECMD(x) ((x) & ~(IOCPARM_MASK << 16))
> #define IOCGROUP(x) (((x) >> 8) & 0xff)
I'm used to the linux definitions but I'm happy to use these instead.
>
> [Prex-devel] [PATCH 11/22] generate stack trace in assert() - useful for
> debug
> =>int3 (breakpoint) has already supported this feature.
I hadn't noticed this - I haven't debugged prex on i386. I may update
my port to use a similar mechanism.
Andrew
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Prex-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/prex-devel