Hi Norm, > From: Norm Jacobs <Norm.Jacobs at Sun.COM> > > Can some folks out there take a look at my SFW changes for the following > bugs > > 6567777 it should be easier to generate package data from the proto > area in the SFW gate > 6597716 sfwnv should not change tool file permissions in the gate. > 6637556 Solaris should ship CUPS > 6675390 common sfw files should install separate from various open > source components > > The webrev is at > > http://cr.opensolaris.org/~jacobs/2008-03-21-sfwnv-cups/ > > I have been building the majority of this for well over a month now and > been running the updated bits for about the same length of time. > Anyway, comments are appreciated.
I didn't see any replies to this so I took a quick skip through look. It looks good to me (as expected :-) ). Couple of minor comments ... 1. was there a reason why you didn't split up the CUPS package up into smaller parts as you had previously suggested (for CCD). 2. do the SUNWcups/copyright & SUNWcupsr/copyright files really need all that lengthy licence stuff in them - it's a right pain when it all comes out when pkgadd'ing pkgs. Could it be put in an 'installed' file and then the pkg's 'copyright' files reference and summarize that (just a thought). Paul (alias paulcun at talk21.com) -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
