On Wed, 2008-09-24 at 21:04 +0200, Andreas Zeidler wrote: > On Wed, 17 Sep 2008 20:13:36 +0200, Roché Compaan > <[EMAIL PROTECTED]> wrote: > > Inside collective.solr's ISearch interface there is the comment "FIXME: > > this should be defined in a generic package". It turns out that I > > actually needed a generic package since I am building a SQL based > > indexer and search dispatcher using SQLAlchemy. So I created a generic > > package named collective.search that contains the interfaces and the > > dispatcher that is currently in collective.solr. I haven't committed > > this yet but like to know if some of the collective.solr developers have > > any objection against me committing collective.search into the > > collective repos. > > no objections -- we haven't started that package yet, because we wanted to > first wait and see what's really needed instead of designing away and > potentially missing the point. but we'll have start eventually. so > please go ahead, perhaps this will help get the discussion going > finally... :)
Ok it's checked in here: https://svn.plone.org/svn/collective/collective.search I made very few changes to the collective.solr implementation: 1. I don't call buildQuery before calling search because this seem solr specific. The implementation simply passes the query args to the search utility. 2. I wrap results in IRecordProxy instead of IFlare since IFlare is also solr specific. IRecordProxy should also be better understood than anything that sounds like a brain ;-) -- Roché Compaan Upfront Systems http://www.upfrontsystems.co.za _______________________________________________ Product-Developers mailing list [email protected] http://lists.plone.org/mailman/listinfo/product-developers
