David Glick <[email protected]> writes: > I've just been reviewing the collective.flowplayer code as part of the > process for approving it for use on our Plone sites. It looks great, > with one exception: we host many Plone sites in one Zope instance, and > want to selectively install collective.flowplayer to only some of > those sites. Based on inspection of the code, it looks like there are > two ways in which collective.flowplayer will pollute the other sites: > > 1. It registers various browser views without specifying a browser > layer.
As long as this doesn't change the "install it and it just works" story and it doesn't require integrators who want to override those views to do something special, I'm all for doing this if it's better practice. Can you point me to how this is done for something like the folder_contents view in Plone? Would it change *anything* for integrators overriding the views? > 2. It subtypes objects in response to object events without checking > to make sure that the object is within a site that has > collective.flowplayer installed. I'm not sure what you're talking about here. Can you please specify all the places this happens? > Both of these should be pretty easy to fix...Can we do that? Once discussion is finished, you're welcome to commit the changes to trunk. :) Ross _______________________________________________ Product-Developers mailing list [email protected] http://lists.plone.org/mailman/listinfo/product-developers
