#651: BibCirculation: improve kwalitee
----------------------------+----------------------
Reporter: simko | Owner: jgarcial
Type: defect | Status: new
Priority: critical | Milestone:
Component: BibCirculation | Version:
Keywords: |
----------------------------+----------------------
BibCirculation update in the //next// branch brought some coding errors
that should be fixed and some kwalitee warnings that should be improved:
{{{
*** bibcirculation_dblayer.py
************* Module bibcirculation_dblayer
E:587:has_copies: function already defined line 574
*** bibcirculation_utils.py
************* Module bibcirculation_utils
E:884:generate_tmp_barcode: Undefined variable 'generate'
*** bibcirculation_cern_ldap.py
W: 74:get_user_info_from_ldap: Redefining built-in 'filter'
W: 29: Unused import decodestring
*** bibcirculation_config.py
W: 29: Unused import CFG_BIBCIRCULATION_AMAZON_ACCESS_KEY
*** bibcirculation_daemon.py
W: 46:task_submit_elaborate_specific_parameter: Unused argument 'args'
W: 46:task_submit_elaborate_specific_parameter: Unused argument 'value'
W: 46:task_submit_elaborate_specific_parameter: Unused argument 'opts'
W:172:update_borrowers_information: Unused variable 'ccid'
W:188:task_run_core: Unused variable 'ccid'
*** bibcirculation_templates.py
W:11645:Template.tmpl_list_acquisition: Unused variable 'due_date'
W:11731:Template.tmpl_ill_request_details_step1: Unused variable
'acq_statuses'
W:12724:Template.tmpl_acq_details_step1: Unused variable 'barcode'
W:16687:Template.tmpl_register_purchase_request_step1: Redefining built-in
'type'
W:16688:Template.tmpl_register_purchase_request_step1: Unused variable
'budget_code'
W:16689:Template.tmpl_register_purchase_request_step1: Unused variable
'period_of_interest_from'
W:16689:Template.tmpl_register_purchase_request_step1: Unused variable
'period_of_interest_to'
W:16690:Template.tmpl_register_purchase_request_step1: Unused variable
'additional_comments'
W:16914:Template.tmpl_register_purchase_request_step2: Redefining built-in
'type'
W:17136:Template.tmpl_register_purchase_request_step2: Unused variable
'ccid'
W:17137:Template.tmpl_register_purchase_request_step2: Unused variable
'phone'
W:17137:Template.tmpl_register_purchase_request_step2: Unused variable
'mailbox'
W:17137:Template.tmpl_register_purchase_request_step2: Unused variable
'address'
W:17136:Template.tmpl_register_purchase_request_step2: Unused variable
'email'
*** bibcirculation_utils.py
E:884:generate_tmp_barcode: Undefined variable 'generate'
W:884:generate_tmp_barcode: Unused variable 'random_number'
*** bibcirculation_webinterface.py
W: 80:WebInterfaceYourLoansPages.index: Unused argument 'form'
W:188:WebInterfaceILLPages.index: Unused argument 'form'
W:452:WebInterfaceILLPages.acq_request_step1: Redefining built-in 'type'
W:467:WebInterfaceILLPages.acq_request_step1: Unused variable 'ln'
W:524:WebInterfaceILLPages.acq_request_step2: Redefining built-in 'type'
W:541:WebInterfaceILLPages.acq_request_step2: Unused variable 'fields'
*** bibcirculationadmin_webinterface.py
W:1897:WebInterfaceBibCirculationAdminPages.register_purchase_request_step1:
Redefining built-in 'type'
W:1934:WebInterfaceBibCirculationAdminPages.register_purchase_request_step2:
Redefining built-in 'type'
W:1972:WebInterfaceBibCirculationAdminPages.register_purchase_request_step3:
Redefining built-in 'type'
*** bibcirculationadminlib.py
W:1128:register_new_loan: Unused variable 'requested_barcode'
W:5017:ill_request_details_step2: Unused argument 'currency'
W:5099:acq_details_step2: Unused variable 'request_type'
W:5092:acq_details_step2: Unused variable 'borrower_id'
W:6185:register_purchase_request_step1: Redefining built-in 'type'
W:6229:register_purchase_request_step2: Redefining built-in 'type'
W:6325:register_purchase_request_step3: Redefining built-in 'type'
W: 67: Unused import CFG_BIBCIRCULATION_ACQ_TYPE
W: 30: Unused import cgi
*** bibcirculation_templates.py
W:1688: Bad indentation. Found 16 spaces, expected 12
W:1689: Bad indentation. Found 16 spaces, expected 12
W:1690: Bad indentation. Found 16 spaces, expected 12
*** bibcirculationadminlib.py
W:3114: Bad indentation. Found 12 spaces, expected 8
W:3115: Bad indentation. Found 12 spaces, expected 8
W:3116: Bad indentation. Found 12 spaces, expected 8
W:3117: Bad indentation. Found 12 spaces, expected 8
}}}
--
Ticket URL: <http://invenio-software.org/ticket/651>
Invenio <http://invenio-software.org>
