On 05/05/2011 01:15 AM, Tibor Simko wrote: > On Thu, 05 May 2011, Joe Blaylock wrote: >> Please find attached a patch to make urlutils' unit test only run the >> hashlib test if hashlib is installed. > > Thanks, commit log amended, and committed.
Great! Thanks. >> hashlib isn't a dependency (actually it's not mentioned in INSTALL at >> all.) > > Indeed, it is not mentioned in the INSTALL guide, since the guide is > meant mostly for production installations and `md5' and `sha' modules > would be used as a fallback when `hashlib' module does not exist. > (Obviously, this concerns only people using Python-2.4; for newer > Pythons, `hashlib' is included with the default Python installation.) > > The only exception, I think, is the AWS connectivity when using > Python-2.4, where `hashlib' would be really needed. In this case an > exception to the admin is raised to alert the admin about the necessity > to install hashlib. > > I have now added a note to the INSTALL file about this use case. oh, I understand now. This makes sense to me; thanks. Joe
