#292: websearch: field tags converted too many places
-------------------------+--------------------------------------------------
Reporter: jblayloc | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: WebSearch | Version:
Keywords: |
-------------------------+--------------------------------------------------
{{{$ grep WEBSEARCH_FIELDS_CONVERT *.py}}}
> search_engine.py: CFG_WEBSEARCH_FIELDS_CONVERT, \
> search_engine.py: if fi and
CFG_WEBSEARCH_FIELDS_CONVERT.has_key(string.lower(fi)):
> search_engine.py: fi =
CFG_WEBSEARCH_FIELDS_CONVERT[string.lower(fi)]
> search_engine.py: if
CFG_WEBSEARCH_FIELDS_CONVERT.has_key(string.lower(f)):
> search_engine.py: f = CFG_WEBSEARCH_FIELDS_CONVERT[f]
> search_engine.py: if
CFG_WEBSEARCH_FIELDS_CONVERT.has_key(string.lower(f)):
> search_engine.py: f =
CFG_WEBSEARCH_FIELDS_CONVERT[string.lower(f)]
This looks like a lot of places to be doing these substitutions, and that
seems dangerous. Also shouldn't this be getting done in the syntax
parser? Philosophically, it seems like search_engine should be, you know,
a search engine.
--
Ticket URL: <http://invenio-software.org/ticket/292>
Invenio <http://invenio-software.org>
