This is an automated notification sent by LCG Savannah.
It relates to:
bugs #45689, project CDS Invenio
==============================================================================
LATEST MODIFICATIONS of bugs #45689:
==============================================================================
Follow-up Comment #3, bug #45689 (project cdsware):
Failing test case fixed by 3d82fa6e147aa4447699b100b425e9eedf990c53.
==============================================================================
OVERVIEW of bugs #45689:
==============================================================================
URL:
<http://savannah.cern.ch/bugs/?45689>
Summary: tagclose in bibrecord.py does not handle singletons
correctly
Project: CDS Invenio
Submitted by: mmarino12
Submitted on: 2009-01-07 19:04
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
Item Group: None
Status: Fixed
Privacy: Public
Assigned to: bthiell
Originator Email:
Open/Closed: Closed
Discussion Lock: Any
_______________________________________________________
The tagclose function does not handle xml singletons correctly (e.g.
<tagname/>) and causes an incorrect error on well-formed xml. The problem
can be fixed with the small change to the tagclose function:
pat_open = '<' + tagname + '.*?>'
should be changed to
pat_open = '<' + tagname + '[^/]*?>'
This disallows matching against singletons.
_______________________________________________________
Follow-up Comments:
-------------------------------------------------------
Date: 2010-01-07 09:58 By: Tibor Simko <simko>
Failing test case fixed by 3d82fa6e147aa4447699b100b425e9eedf990c53.
-------------------------------------------------------
Date: 2009-12-13 21:52 By: Tibor Simko <simko>
Fixed by Benoit in 34c80f205a38521f1f0c1c7af4a12aeac413958e.
One test case still `slightly' failing (just the field order number problem).
Left failing in the TDD style.
-------------------------------------------------------
Date: 2009-01-07 19:19 By: Mike Marino <mmarino12>
I've also found there are a few other issues in bibrecord that don't handle
singletons correctly.
e.g. in create_record_RXP, one will receive iteration over non-sequence
errors as some of the code tries to iterate over 'None'. This could be
solved by adding the ExpandEmpty=1 flag to the parse command:
root1 = pyrxp_parser.parse(xmltext, ExpandEmpty=1)
which turns singletons into empty lists instead of None.
I don't know about the code for the other parsing engines.
_______________________________________________________
Carbon-Copy List:
CC Address | Comment
------------------------------------+-----------------------------
1576 | -COM-
4043 | -UPD-
2800 | -SUB-
==============================================================================
This item URL is:
<http://savannah.cern.ch/bugs/?45689>
_______________________________________________
Message sent via/by LCG Savannah
http://savannah.cern.ch/
