This is an automated notification sent by LCG Savannah.
It relates to:
task #13112, project CDS Invenio
==============================================================================
LATEST MODIFICATIONS of task #13112:
==============================================================================
Follow-up Comment #3, task #13112 (project cdsware):
Well, the tests pass before and after, and the changes I made were to make it
more obvious what was happening there. So I feel it should be safe, yes.
==============================================================================
OVERVIEW of task #13112:
==============================================================================
URL:
<http://savannah.cern.ch/task/?13112>
Summary: Skipped test should not fail
Project: CDS Invenio
Submitted by: vengmark
Submitted on: 2009-12-14 15:29
Should Start On: 2009-12-14 00:00
Should be Finished on: 2009-12-14 00:00
Category: BibEdit
Priority: 5 - Normal
Status: Done
Privacy: Public
Percent Complete: 100%
Assigned to: simko
Open/Closed: Closed
Discussion Lock: Any
Effort: 0.00
_______________________________________________________
Output from latest Git master, command
sudo -u www-data /opt/cds-invenio/bin/inveniocfg --run-unit-tests
:
FAIL: bibrecord - create_record() with pyRXP
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/local/lib/python2.6/dist-packages/invenio/bibrecord_tests.py",
line 128, in test_pyRXP
self.fail("SKIPPED: pyRXP not available, test skipped.")
AssertionError: SKIPPED: pyRXP not available, test skipped.
AFAIK, a test should not fail if there is nothing wrong.
_______________________________________________________
Follow-up Comments:
-------------------------------------------------------
Date: 2009-12-14 21:48 By: Joe Blaylock <jblayloc>
Well, the tests pass before and after, and the changes I made were to make it
more obvious what was happening there. So I feel it should be safe, yes.
-------------------------------------------------------
Date: 2009-12-14 20:47 By: Tibor Simko <simko>
(Joe, sorry for not replying sooner to your branch)
1) WRT tests, I agree we should skip them gracefully, but better yet,
we should not even attempt to run them if they are not applicable.
I've just committed a fix in this respect for these and other similar
tests, so closing this task.
2) WRT bibrecord refactoring, I'm kind of reluctant to accept pure
refactoring patches in this pre-release period -- you know, the good
old ``if it ain't broke don't fix it'' philosophy. But since this
function has nice test cases, it may be okay to go, if you feel safe
about it :). Please tell me.
-------------------------------------------------------
Date: 2009-12-14 17:41 By: Joe Blaylock <jblayloc>
I agree with Victor.
Indeed, I fixed this issue more than a month ago in my branch,
"BibRecordFixups". I realize now that I mistakenly emailed only to Tibor,
who probably lost the message in his daily deluge of email, rather than
sending it to the list.
The web page of the commit to which I refer is:
http://cdsware.cern.ch/repo/?p=personal/cds-invenio-jrbl.git;a=commit;h=bde2c7e02b0ce1a965f52da359ff8a280bc8e8e9
The explanation I included in my earlier message is as follows:
"While I was working on something else, I found myself wanting to extend the
BibRecord API. But before I did that, I wanted to run the tests, make sure
everything passed, and then write new tests for the API feature I wanted. I
was surprised when all of the unit tests didn't pass.
Since the features that were being tested for are optional, it's not strictly
correct that those tests fail - so I made them emit a warning and pass,
instead.
Also, I initially thought I could get the API functionality I wanted by
extending record_get_field_values in a fully backwards-compatible way. But I
found it hard to read, so I rewrote it to be more understandable (and
confirmed that all tests continue to pass).
Of course, now I realize what I need is a whole new call. But that's a
separate problem, and I thought I should push these items out first."
_______________________________________________________
Carbon-Copy List:
CC Address | Comment
------------------------------------+-----------------------------
1576 | -COM-
5878 | -COM-
3964 | -SUB-
==============================================================================
This item URL is:
<http://savannah.cern.ch/task/?13112>
_______________________________________________
Message sent via/by LCG Savannah
http://savannah.cern.ch/
