This is an automated notification sent by LCG Savannah.
It relates to:
task #8635, project CDS Invenio
==============================================================================
LATEST MODIFICATIONS of task #8635:
==============================================================================
Update of task #8635 (project cdsware):
Status: None => Done
Percent Complete: 0% => 100%
Assigned to: nkasioum => None
Open/Closed: Open => Closed
_______________________________________________________
Follow-up Comment #2:
The bug had already been fixed in the latest sources but had gone unreported.
Now it is also fixed in the production site. Still a patch was submitted to
optimize the code and address the bug directly:
[PATCH] WebBasket: add to baskets optimization
* optimized code when the user tries to add records
without selecting any baskets. (closes #8635)
* optimized code when the user tries to add records
to a basket he does not have rights on.
==============================================================================
OVERVIEW of task #8635:
==============================================================================
URL:
<http://savannah.cern.ch/task/?8635>
Summary: Crash in WebBasket
Project: CDS Invenio
Submitted by: skaplun
Submitted on: 2008-12-10 12:42
Should Start On: 2008-12-10 00:00
Should be Finished on: 2008-12-10 00:00
Category: WebBasket
Priority: 9 - Immediate
Status: Done
Privacy: Private
Percent Complete: 100%
Assigned to: None
Open/Closed: Closed
Discussion Lock: Any
Effort: 0.00
_______________________________________________________
uri: </yourbaskets/add?ln=en>
>>> Traceback details
Forced traceback (most recent call last)
File "/usr/lib64/python2.3/site-packages/mod_python/apache.py", line 299,
in HandlerDispatch
result = object(req)
File "/usr/lib64/python2.3/site-packages/invenio/webinterface_handler.py",
line 320, in _profiler
return _handler(req)
Traceback (most recent call last):
File "/usr/lib64/python2.3/site-packages/invenio/webinterface_handler.py",
line 362, in _handler
return root._traverse(req, path, False, guest_p)
File "/usr/lib64/python2.3/site-packages/invenio/webinterface_handler.py",
line 207, in _traverse
return obj._traverse(req, path, do_head, guest_p)
File "/usr/lib64/python2.3/site-packages/invenio/webinterface_handler.py",
line 226, in _traverse
result = _check_result(req, obj(req, form))
File
"/usr/lib64/python2.3/site-packages/invenio/webbasket_webinterface.py", line
400, in add
ln=argd['ln'])
File "/usr/lib64/python2.3/site-packages/invenio/webbasket.py", line 436,
in perform_request_add
nb_modified_baskets = db.add_to_basket(uid, validated_recids, bskids)
File "/usr/lib64/python2.3/site-packages/invenio/webbasket_dblayer.py",
line 447, in add_to_basket
bsks.update(dict(run_sql(query1, params)))
File "/usr/lib64/python2.3/site-packages/invenio/dbquery.py", line 217, in
run_sql
rc = cur.execute(sql, param)
File "/usr/lib64/python2.3/site-packages/MySQLdb/cursors.py", line 166, in
execute
self.errorhandler(self, exc, value)
File "/usr/lib64/python2.3/site-packages/MySQLdb/connections.py", line 35,
in defaulterrorhandler
raise errorclass, errorvalue
ProgrammingError: (1064, "You have an error in your SQL syntax; check the
manual that corresponds to your MySQL
server version for the right syntax to use near 'GROUP BY id_bskBASKET' at
line 5")
_______________________________________________________
Follow-up Comments:
-------------------------------------------------------
Date: 2009-08-05 13:15 By: Nikolaos Kasioumis <nkasioum>
The bug had already been fixed in the latest sources but had gone unreported.
Now it is also fixed in the production site. Still a patch was submitted to
optimize the code and address the bug directly:
[PATCH] WebBasket: add to baskets optimization
* optimized code when the user tries to add records
without selecting any baskets. (closes #8635)
* optimized code when the user tries to add records
to a basket he does not have rights on.
-------------------------------------------------------
Date: 2009-04-21 11:25 By: Samuele Kaplun <skaplun>
New details:
referer:
<http://cdsweb.cern.ch/yourbaskets/add?new_basket_name=&new_topic_name=&ln=en&of=&create_in_topic=-1&referer=&recid=477613>
And we now know that this happens when adding a record without specifying any
basket (although baskets do exists).
_______________________________________________________
Carbon-Copy List:
CC Address | Comment
------------------------------------+-----------------------------
4752 | -COM-
skaplun | Voted in favor of this item
[email protected] |
2195 | -SUB-
==============================================================================
This item URL is:
<http://savannah.cern.ch/task/?8635>
_______________________________________________
Message sent via/by LCG Savannah
http://savannah.cern.ch/
