This is an automated notification sent by LCG Savannah.
It relates to:
task #9398, project CDS Invenio
==============================================================================
OVERVIEW of task #9398:
==============================================================================
URL:
<http://savannah.cern.ch/task/?9398>
Summary: BibCirculation: improve coding
Project: CDS Invenio
Submitted by: simko
Submitted on: 2009-03-27 12:12
Should Start On: 2009-03-27 00:00
Should be Finished on: 2009-03-27 00:00
Category: BibCirculation
Priority: 7 - High
Status: None
Privacy: Public
Percent Complete: 0%
Assigned to: jsilvest
Open/Closed: Open
Discussion Lock: Any
Effort: 0.00
_______________________________________________________
Coding in BibCirculation should be improved. Examples (some more urgent than
others):
* All the "if foo != None" comparisons should be fixed, using either "if foo"
technique, or if needed "if foo is not None" technique. See PEP 8.
* Empty docstrings should not be used, as in:
def get_item_requests_historical_overview(recid):
"""
"""
They should be either completed, or removed.
* Variable warnings should be fixed, some of these may be serious. If some
variables are dummy in their use, then use a "dummy" prefix for them, so that
pylint does not complain.
W:1223:new_borrower: Unused variable 'res'
W:1379:Template.tmpl_item_search_result: Unused variable 'nb_records'
W:2082:Template.tmpl_all_requests: Unused variable 'name_link'
W:2087:Template.tmpl_all_requests: Unused variable 'item_link'
W:2093:Template.tmpl_all_requests: Unused variable 'status_link'
W:2186:Template.tmpl_get_item_requests_details: Unused variable 'name_link'
W:2193:Template.tmpl_get_item_requests_details: Unused variable
'status_link'
W:221:WebInterfaceHoldingsPages.display: Unused variable 'order'
W:2228:Template.tmpl_get_item_requests_details: Unused variable
'cancel_request_link'
W:2260:Template.tmpl_get_item_requests_details: Using possibly undefined loop
variable 'recid'
W:3100:Template.tmpl_borrower_request_details: Unused variable 'borid'
W:310:WebInterfaceHoldingsPages.request: Unused variable 'order'
W:3825:Template.tmpl_associate_barcode: Unused variable 'book_author'
W:3825:Template.tmpl_associate_barcode: Unused variable 'book_editor'
W:3825:Template.tmpl_associate_barcode: Unused variable 'book_year'
W:399:WebInterfaceHoldingsPages.send: Unused variable 'order'
W:4677:Template.tmpl_update_borrower_info_step3: Unused variable
'borrower_id'
W:5133:Template.tmpl_update_library_info_step3: Unused variable 'notes'
W:5205:Template.tmpl_update_library_info_step4: Unused variable 'library_id'
W:5523:Template.tmpl_add_new_copy_step3: Unused variable 'today'
W:707:loan_on_desk_step5: Unused variable 'ccid'
W:979:Template.tmpl_get_next_waiting_loan_request: Unused variable
'select_link'
_______________________________________________________
Carbon-Copy List:
CC Address | Comment
------------------------------------+-----------------------------
1576 | -SUB-
==============================================================================
This item URL is:
<http://savannah.cern.ch/task/?9398>
_______________________________________________
Message sent via/by LCG Savannah
http://savannah.cern.ch/
