Hi to all,

In the DEMOBOO (refereed) submission, during the approval/rejection of a document, the "Comments on the Decision" textArea element (DEMOBOO_COMNT field) is NOT mandatory to complete (and this seems correct).

However, in the Send_APP_Mail function, if the comments_file parameter value IS set (in the websubmit gui), and a comment is NOT supplied by the user for this specific submission (he is allowed to do so), an exception is thrown.

The solution is dead simple: either you make the field mandatory, or (better) you apply to Send_APP_Mail.py something like:

105c125,128
<         try:
---
      # TeD - don't give an exception if there is no comments file
      # It may have been defined, but not completed by the user
      # In the appropriate form. It is NOT vital for the Approval!
        if os.path.exists("%s/%s" % (curdir, comments_filename)):
109,117d131
<         except IOError:
<             ## Oops, unable to open the comments file.
<             comment = ""
<             exception_prefix = "Error in WebSubmit function " \
<                                "Send_APP_Mail. Tried to open comments " \
<                                "file [%s/%s] but was unable to." \
<                                % (curdir, comments_filename)
<             register_exception(prefix=exception_prefix)
<         else:
118a133,134
      else:
            comment = ""


Best regards,
Theodoros


Reply via email to