This is an automated notification sent by LCG Savannah.
It relates to:
task #6497, project CDS Invenio
==============================================================================
LATEST MODIFICATIONS of task #6497:
==============================================================================
Update of task #6497 (project cdsware):
Status: None => Done
Percent Complete: 90% => 100%
Open/Closed: Open => Closed
_______________________________________________________
Follow-up Comment #3:
Testing has been done.
Opening a new task for the work remaining on WebJournal.
==============================================================================
OVERVIEW of task #6497:
==============================================================================
URL:
<http://savannah.cern.ch/task/?6497>
Summary: Complete support for 'req' object in BibFormat
Project: CDS Invenio
Submitted by: jcaffaro
Submitted on: 2008-02-27 13:52
Should Start On: 2008-02-27 00:00
Should be Finished on: 2008-02-27 00:00
Category: BibFormat
Priority: 8
Status: Done
Privacy: Public
Percent Complete: 100%
Assigned to: jcaffaro
Open/Closed: Closed
Discussion Lock: Any
Effort: 0.00
_______________________________________________________
The BibFormatObject class has a 'req' member, which can be used in the format
elements to retrieve information about the current request. However
BibFormatObject.req is never assigned a value.
Modify function definitions in bibformat_engine.py and bibformat.py to pass
this req object as parameter.
Also modify search_engine.py to call bibformat.format_record() with the 'req'
object as parameter.
_______________________________________________________
Follow-up Comments:
-------------------------------------------------------
Date: 2008-03-10 12:06 By: Jerome Caffaro <jcaffaro>
Testing has been done.
Opening a new task for the work remaining on WebJournal.
-------------------------------------------------------
Date: 2008-03-03 07:03 By: Jerome Caffaro <jcaffaro>
Deprecated bfo.req and bfo.uid in favour of bfo.user_info
(req and uid are still accessible for compatibility reasons but will
disappear in the future).
More testing is needed, especially in bibreformat + other cases where calling
BibFormat with req=None.
WebJournal module still heavily relies on bfo.req. The BibFormatObject is
therefore assigned a req value in this very special case. WebJournal should
make use of bfo.user_info in the future.
-------------------------------------------------------
Date: 2008-02-27 14:21 By: Tibor Simko <simko>
format_record() has currently an 'uid' parameter. Adding 'req' could make a
kind of dual use with it, to some extent. Unless format_record() wants to
call req.write() and friends, maybe it would be cleaner to introduce
'user_info' as a single parameter there. One can access all information
about user agent via 'user_info', and passing 'user_info' instead of 'req'
looks cleaner with respect to the separation of the outputting layer and the
business logic layer. (Needless to say, pages such as search engine that are
to be written progressively must have access to req, but they should be rather
exceptions...)
In fact, 'user_info' should be preferable to 'uid' everywhere in the Invenio
codebase, but that is quite a massive code change to implement...
_______________________________________________________
Carbon-Copy List:
CC Address | Comment
------------------------------------+-----------------------------
1576 | -COM-
2407 | -SUB-
==============================================================================
This item URL is:
<http://savannah.cern.ch/task/?6497>
_______________________________________________
Message sent via/by LCG Savannah
http://savannah.cern.ch/
