Hello I have pushed current state of my BibDoc modifications branch into my public repository (because of several similarly named branches, it is called bibdocfile-ultimateextensions )
I would be grateful for any comments. (The branch is missing some unit tests and the modifications to BibUpload which will be added soon). Subclasses of BibDoc are loaded as plugins and dynamically loaded based on the type of document. Creation happens via static factory class rather than the constructor. (Would work too but without loading appropriate subclass). MoreInfo is an independent entity in the database that can be attached to more objects. It is now stored in bibdoc_moreinfo database table and the granularity has been increased. Also the MoreInfo class features changed semantics. Now changes are stored directly in the database. (It is easy to go to previous state with caching values and them flushing them. What do You think about this solution ? I had several problems with indices on NULL columns (creation of sparse table for MoreInfo). It is not ellegant, how new entreis are created (there should be a transaction.... INSERT INTO ... ON DUPLICATE does not work correctly with NULLs because multi[ple entries with NULL can be inserted). Any suggestions, how to improve this ? I will be now implementing extensions to BibUpload (hopefully a small thing). With current more independent implementation of MoreInfo, I am not sure if we still need a separate class for version of an object. (Maybe it can be still represented as it is right now ? ) cheers Piotr
