Hi Theodoros, Il giorno ven, 04/11/2011 alle 14.12 +0200, Theodoros Theodoropoulos ha scritto: > I've spotted a small typo that produces wrong results in > oai_repository_server (both in the release and the trunk versions).
Thanks for reporting this. Actually, the OAI server implementation has been rewritten from scratch, but it has not yet been merged into master branch yet (although it should now happen in the next few days hopefully). The reimplementation is available in my branch sam/fast-oai: <http://invenio-software.org/repo/personal/invenio-sam/commit/?h=fast-oai&id=029d53f659b45f3b08281e1780bcf11528192ef0> I will check that the bug you report do not exist anymore. > Furthermore, around line 746, I think there is another syntax error in > return md5(str(time.time())).hexdigest() > > It think it should probably be something like > return md5.new(str(time.time())).hexdigest() > I think that the original code is still correct because at the beginning the import is: from md5 import md5 (or from hashlib import md5 on newer Pythons) And from the Python guide: [...] md5.md5([arg]) For backward compatibility reasons, this is an alternative name for the new() function. [...] It's true that for newer code we should rather use new() though. Cheers! Sam -- Samuele Kaplun Invenio Developer ** <http://invenio-software.org/>
