#604: bibknowledge needs updates to better support autocomplete
---------------------------+----------------------------
Reporter: jblayloc | Owner: jblayloc
Type: defect | Status: infoneeded
Priority: major | Milestone:
Component: BibKnowledge | Version:
Resolution: | Keywords: review:skaplun
---------------------------+----------------------------
Changes (by skaplun):
* status: in_merge => infoneeded
Comment:
Hi Joe,
I gave a 1st brief look at your branch. For the time being I just have
only few small questions/doubts:
* I see you changed in several places the signature of functions (e.g. by
removing some parameter). I am not aware if you are also responsible for
the BibEdit part, but could you confirm otherwise that BibEdit will be
happy with your API changes?
* In your unit/regression tests (great you added so many!), you should
follow the Invenio convention of putting unit tests into a
bibknowledge_tests.py and regression tests into
bibknowledge_regression_tests.py. In this way they will be called
appropriately when using {{{inveniocfg --run-unit-tests}}} Vs. {{{--run-
regression-tests}}}
* I remember you (whas it you?) told me IRL you thought it was more
consistent to put {{{json}}} as format type in kb_export, rather than
{{{jquery}}}. I fully agree with this, so you can change it if you like,
and I will consequently update my OpenAIRE branch to provide the more
correct {{{json}}} value.
* You can add {{{(closes #604)}}} in your commit log so that as soon as
your branch will be merged into Invenio, this ticket will be well closed.
I will give a further look and in case add more comments. Cheers!!
Sam
--
Ticket URL: <http://invenio-software.org/ticket/604#comment:5>
Invenio <http://invenio-software.org>
