Hi!
In data giovedì 23 febbraio 2012 11:49:57, hai scritto:
> I would like to point out an error with the #820 fix on the function
> parse_runtime_limit() in datetutils with respect to reversed time ranges.
> I encountered the same error on my side a few days ago and I fixed it on my
> cloned repo.
> [...]
>
> Before any fix only the second mail was received.
> With the current #820 fix only the first one is received.
> With a quick fix of mine both mails are received.
> [...]
>
> Another easy way to see the problem is to run this python code :
> [...]
> Here is my patch with respect to the master
> 3d86a43c05bb17169265a58531db07154c8feec3.
> It makes parse_runtime_limit take into consideration not only the date but
> also the current time so that the function docstring is respected.
> "The function will return two valid time ranges.
> The first could be in the past, containing the present or in the future.
> The second is always in the future."
> [...]
> Any thought on that ?
> Regards.
After so many moons, we come back to your email that we have not yet answered!
So sorry about that.
Indeed your patch looks pretty good and we would like to merge it.
As you might have noticed all our source files comes, by policy, with the GPL2
license and have copyright "CERN". Would you agree if we integrate your patch
under CERN copyright, while still crediting you in the GIT commit log and in
the THANKS files? Would you like to be represented with your nickname "0xdec0"
or do you have a full name that we can use?
Best regards,
Samuele
--
Samuele Kaplun
Invenio Developer ** <http://invenio-software.org/>
