Hi,
In the pu branch, the lang¹ and dir² are set in two places *and* in two
different ways.
49: <html{% if g.ln %} lang="{{ g.ln|safe }}"{% if is_language_rtl(g.ln)
%} dir="rtl"{% endif %}{% endif %}>
99: <body{% if g.ln %} lang="{{ g.ln.split('_', 1)[0]|safe }}"{% if
rtl_direction %} {{ rtl_direction|safe }}{% endif %}{% endif %}>
https://github.com/jirikuncar/invenio/blob/pu/invenio/base/templates/page_base.html#L49
The master, 1.1 and 1.0 branches are quite similar, only the lang is
repeated though:
369: <html lang="%(ln_iso_639_a)s" xml:lang="%(ln_iso_639_a)s">
394: <body lang="%(ln_iso_639_a)s"%(rtl_direction)s>
*
http://invenio-software.org/repo/invenio/tree/modules/webstyle/lib/webstyle_templates.py#n369
*
http://invenio-software.org/repo/invenio/tree/modules/webstyle/lib/webstyle_templates.py?h=maint-1.1#n334
*
http://invenio-software.org/repo/invenio/tree/modules/webstyle/lib/webstyle_templates.py?h=maint-1.0#n319
Is there a good reason for having (or keeping) those duplications?
I have the feeling that having it only in the <html> tag is good enough.
Just like the specification's examples (see links in the P.S.).
Cheers,
--
Yoan
¹ http://www.w3.org/TR/html401/struct/dirlang.html#h-8.1
² http://www.w3.org/TR/html401/struct/dirlang.html#h-8.2
