Hi Ferran, In data Thursday 10 March 2016 16:44:11, Ferran Jorba ha scritto: > I was debugging the list of our exposed OAI sets, because it listed > some garbage that didn't make any sense to us. Tracing the code I > found the long commit ee9a940 > (https://github.com/inveniosoftware/invenio/commit/ee9a940e254681f7b7f215374 > ee11426440ac3d5) where it states that, after doing a SELECT on the > correspondent table, the software lists sets after expanding values from > CFG_OAI_SET_FIELD > (https://github.com/inveniosoftware/invenio/commit/ee9a940e254681f7b7f21537 > 4ee11426440ac3d5#diff-06d340735fa484680e1d350a414e149fR725). Even provided > with this knowledge, I haven't been able to understand the garbage ListSets > was publishing. After creating a local patch that deletes the two > expansion loops, now the result is what is stated in the the oaiREPOSITORY > table and thus, visible through the OAI > Repository Admin Interface. > > Is there a general reason for keeping this expansion for everyone? Or > is it maybe a local CERN patch that could be enclosed in a > CFG_CERN_SITE or so?
This was implemented in order to automatically implement nested sets definition: <http://www.openarchives.org/OAI/2.0/guidelines-repository.htm#Sets-Hierarchy> If you want to propose a patch, maybe, rather than protecting this expansion behind if CFG_CERN_SITE, you can protect it behind CFG_OAI_HIERARCHICAL_SETS (with default True). Cheers! Sam -- Samuele Kaplun INSPIRE Service Manager ** <http://inspirehep.net/>
