Marvin, Thank you for your contribution! I have asked Rainer to review the PR (I will also take a look when I get a chance).
--Radu From: [email protected] <[email protected]> On Behalf Of Marvin Sent: Wednesday, April 26, 2023 9:57 AM To: ProjectChrono <[email protected]> Subject: [chrono] Re: Code Contribution MF5.2/6.2 Tire Model Hi Rainer, Thanks, I have not made a public PR to a large project like this before, but I opened one here (fingers crossed): https://github.com/projectchrono/chrono/pull/450 The reason for the contribution is that the existing models are quite dated, the MF5.2/6.2 should be more relevant and up to date with the industry standards. That said, I did not have access to the TNO/SIEMENS MF-TIRE model, so I could not do a like-for-like comparison. My implementation is based on the open source MFEval, which seems to be correlated against the MF-TIRE model. Mine is correlated in steady state to the MFEval model for the given default parameter files, but I have not validated the transient behaviour and this needs work/review. On Tuesday, April 25, 2023 at 2:29:31 PM UTC+2 [email protected]<mailto:[email protected]> wrote: Hi Marvin, thanks for your interest in chrono and its tire models. A solution like this sounds interesting to me. While we already have a working Pacejka 2002 version, we are open for any solution, which is probably better or more complete. I know there are also matlab tools for magic formula curve fitting, so that would be worth to deal with. A standard way to contribute to chrono is to generate a pull request. So please try this first. Thanks Rainer Marvin schrieb am Donnerstag, 20. April 2023 um 11:55:36 UTC+2: Dear Project Chrono Developers, I've ported the MF 5.2/6.2 tire model from https://www.mathworks.com/matlabcentral/fileexchange/63618-mfeval to C++ and integrated it with Project Chrono. It works fine, but the relaxation model requires some further work and perhaps the code style code use some improvement. I would like to contribute this if this is of interest to you. Do you have any suggestions on how to proceed? Kind regards, Marvin -- You received this message because you are subscribed to the Google Groups "ProjectChrono" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]<mailto:[email protected]>. To view this discussion on the web visit https://groups.google.com/d/msgid/projectchrono/c70329bc-3d05-494c-aa5d-3563f713ae90n%40googlegroups.com<https://groups.google.com/d/msgid/projectchrono/c70329bc-3d05-494c-aa5d-3563f713ae90n%40googlegroups.com?utm_medium=email&utm_source=footer>. -- You received this message because you are subscribed to the Google Groups "ProjectChrono" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/projectchrono/PH0PR06MB82377476E51A9907F8B50A9AA7659%40PH0PR06MB8237.namprd06.prod.outlook.com.
