I would build everything on master, that way we catch *before* starting a release if there is something wrong.
/MR On Wed, Feb 12, 2020 at 8:37 AM Sylvain Rabot <[email protected]> wrote: > I did not say it but I was speaking of prometheus/prometheus, I haven't > checked others repos for their full cross-building time. > > I think we can come up with a minimal list of GOOS/GOARCH for PRs but, if > you think building the complete list on tags only is not enough, we could > do it on tags & master. > > If we were to choose to build the complete list for tags only I would > suggest to build this for PRs: > > - linux/amd64 > - linux/386 > - linux/arm > - linux/arm64 > - darwin/amd64 > - windows/amd64 > - freebsd/amd64 > - openbsd/amd64 > - netbsd/amd64 > - dragonfly/amd64 > > If we were to choose to build the complete list for tags & master then I > would suggest an even more reduced one: > > - linux/amd64 > - darwin/amd64 > - windows/amd64 > - freebsd/amd64 > > Regards. > > On Tue, 11 Feb 2020 at 23:17, Matthias Rampke <[email protected]> wrote: > >> There are some exceptions like node exporter where it's important that >> all variants at least build, but that has a custom setup already. >> >> What would be a sufficient subset? Do we need to worry about endianness >> and 32 bit architectures, or would just building not catch issues specific >> to these anyway? >> >> /MR >> >> On Tue, 11 Feb 2020, 22:50 Krasimir Georgiev, <[email protected]> >> wrote: >> >>> I think that is a very good idea. >>> >>> On Feb 11 2020, at 11:19 pm, Sylvain Rabot <[email protected]> >>> wrote: >>> >>> Hi, >>> >>> >>> I'm wondering if we could reduce the list of GOOS/GOARCH that are >>> crossbuilt for every PR by circle-ci. >>> >>> >>> The building of the complete list seems like a waste of time & resources to >>> me. >>> >>> >>> Maybe we could select a few and only build the complete list when building >>> tags ? >>> >>> >>> Regards. >>> >>> >>> -- >>> Sylvain Rabot <[email protected]> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Prometheus Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/prometheus-developers/CADjtP1FJKyVj_gq-hgVgyyVbJ%3D-pECFqcPK-QviXmKB1R-oAgg%40mail.gmail.com >>> <https://groups.google.com/d/msgid/prometheus-developers/CADjtP1FJKyVj_gq-hgVgyyVbJ%3D-pECFqcPK-QviXmKB1R-oAgg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Prometheus Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/prometheus-developers/2508CDF1-CC2A-4AC6-B9EE-D68B53AFF166%40getmailspring.com >>> <https://groups.google.com/d/msgid/prometheus-developers/2508CDF1-CC2A-4AC6-B9EE-D68B53AFF166%40getmailspring.com?utm_medium=email&utm_source=footer> >>> . >>> >> > > -- > Sylvain Rabot <[email protected]> > -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAFU3N5V6MiMGH32a4OB0KMfJmV7FBZbJWEe6HZ-z9%2BmiOkqusQ%40mail.gmail.com.
