On 16 Feb 12:52, Sylvain Rabot wrote:
> I strongly believe that TSDB is a cornerstone of the prometheus ecosystem
> (and not prometheus/prometheus alone) and as such should have its own
> lifecycle.
>
> I also believe the original reason for the move ("Keeping them in sync,
> versioning etc, is a pain") should have been solved by tooling.
>
> I'm sure at one point people using TSDB outside of prometheus will complain
> about the TSDB versioning being tied to prometheus.
>
> So I'd like to make sure we can go back because even if the move is
> considered safe now, I'm persuaded it only benefits internal prometheus
> developments at the expense of the whole ecosystem.
>
> Regards.There are discussions in progress outside of this discussion. I would like to add that golang versioning totally tolerate multiple modules in one git repo with different versioning schemes. https://github.com/hashicorp/consul/tree/master/api is a go module on its own, module github.com/hashicorp/consul/api inside the github.com/hashicorp/consul repo. They have dedicated versions (see https://github.com/hashicorp/consul/tree/api/v1.4.0): consul/api is v1.4.0, while consul is v1.7.0. So it looks like we could get the advantages of a single repo and a dedicated module lifecycle if we need to. > > On Sun, 16 Feb 2020 at 12:39, Bartłomiej Płotka <[email protected]> wrote: > > > Hm, why would it need to have its own lifecycle? > > > > We waited for some time exactly to make sure that all is safe for the move. > > > > Bartek > > > > On Sun, 16 Feb 2020, 11:25 Sylvain Rabot, <[email protected]> wrote: > > > >> Hi, > >> > >> Before doing so, could we make sure this action can be reverted ? > >> > >> I'd hate that, if we realize TSDB needs its own lifecycle, we wouldn't be > >> able to reopen github.com/prometheus/tsdb because of some github logic. > >> > >> Regards. > >> > >> On Fri, 14 Feb 2020 at 00:19, Julien Pivotto <[email protected]> > >> wrote: > >> > >>> Dear community, > >>> > >>> In the dev summit 2019/1, it was decided to move tsdb to the junkyard: > >>> > >>> https://docs.google.com/document/d/1NQIX78nwBhfLZD3pAb0PK-uBKYqnkzjjVhOQ-kIaEGU/edit > >>> > >>> The https://github.com/prometheus/tsdb has been moved in Augustus 2019 > >>> inside > >>> the prometheus repo itself: > >>> https://github.com/prometheus/prometheus/tsdb > >>> > >>> I would like to trigger the move of the old repo to > >>> https://github.com/prometheus-junkyard/tsdb at the end of this month (29 > >>> February). That is 200 days after the repo has been merged in the > >>> prometheus server repo. > >>> > >>> GitHub says that "All links to the previous repository location are > >>> automatically redirected to the new location": > >>> > >>> https://help.github.com/en/github/administering-a-repository/transferring-a-repository > >>> which means that links to pull requests etc should still work after > >>> the rename. > >>> > >>> If someone has strong arguments against this, please reply to this > >>> message. > >>> > >>> -- > >>> (o- Julien Pivotto > >>> //\ Open-Source Consultant > >>> V_/_ Inuits - https://www.inuits.eu > >>> > >>> -- > >>> You received this message because you are subscribed to the Google > >>> Groups "Prometheus Developers" group. > >>> To unsubscribe from this group and stop receiving emails from it, send > >>> an email to [email protected]. > >>> To view this discussion on the web visit > >>> https://groups.google.com/d/msgid/prometheus-developers/20200213231949.GA18483%40oxygen > >>> . > >>> > >> > >> > >> -- > >> Sylvain Rabot <[email protected]> > >> > >> -- > >> You received this message because you are subscribed to the Google Groups > >> "Prometheus Developers" group. > >> To unsubscribe from this group and stop receiving emails from it, send an > >> email to [email protected]. > >> To view this discussion on the web visit > >> https://groups.google.com/d/msgid/prometheus-developers/CADjtP1GFSFug0WYQO0svnJv2%3D2Xgz-GSzfL1ThN_kHeoznOQsg%40mail.gmail.com > >> <https://groups.google.com/d/msgid/prometheus-developers/CADjtP1GFSFug0WYQO0svnJv2%3D2Xgz-GSzfL1ThN_kHeoznOQsg%40mail.gmail.com?utm_medium=email&utm_source=footer> > >> . > >> > > > > -- > Sylvain Rabot <[email protected]> -- (o- Julien Pivotto //\ Open-Source Consultant V_/_ Inuits - https://www.inuits.eu -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/20200216120005.GA19661%40oxygen.
signature.asc
Description: PGP signature
