mandag den 2. marts 2020 kl. 14.18.35 UTC+1 skrev Björn Rabenstein: > > On 26.02.20 21:51, Julien Pivotto wrote: > > > > I think we can offer @Skeen to maintain the repo in > > prometheus-community, if they are interested. > > OK, I'll take that as another vote for prometheus-community. > > > Before moving to community, it looks like > > https://github.com/magenta-aps/check_prometheus_metric is not following > > our guidelines regarding logos as the prometheus logo orange+black does > > not exist. > > It's not so much "our" guidelines as the LF trademark guidelines. > > I honestly don't think this is a good time to start to be anal about > it. If we _actually_ want to follow the LF trademark guidelines > strictly, we should start with ourselves. The logo animations in the > PromCon videos are certainly more invasive that simple background > color changes. Personally, I have changed backgroud colors a lot for > slides etc. (One might argue, the white parts in the logo are actually > not white but transparent, anyway.) The PGW deliberately uses a > color-inverted version of the logo as a favicon. > > > > 2. We deprecate prometheus/nagios_plugins and refer to a 3rd party > > > integration (possibly based on forking prometheus/nagios_plugins) that > > > is properly maintained and developed. In this case, I'd keep the > > > existing repo around until further notice, but not accepting any > > > contributions besides important bug fixes. > > > > Our doc says that in that case it should be moved to junkyard > > https://prometheus.io/governance/#how-do-i-archive-or-remove-a-project > > That's not what the doc says. It only describes how to archive or > remove a project. I don't want to archive or remove the old repo, at > least not for a very generously measured transition period. I expect a > _lot_ of people using this simple script for some legacy Nagios > integration, and they are perfectly happy with the current state. I > don't want to break them as long as it doesn't cause us any effort to > keep things around. The situation would be different if the existing > repo would be a complex piece of software. > > > > Emil 'Skeen' Madsen, @Skeen on GH, filed above mentioned issue #25, > > > and he is already playing around with a feature-enriched fork. I would > > > now like to encourage Nagios/Icinga users to try out his fork, to be > > > found under https://github.com/magenta-aps/check_prometheus_metric > and > > > give Emil feedback. If that turns out well, I suggest to go for > > > option (2), deprecate prometheus/nagios_plugins in lieu of > > > agenta-aps/check_prometheus_metric and list the latter as an > > > integration on https://prometheus.io > > > > I would prefer to have it moved to community, maybe moved+renamed > > check_prometheus_metric, and be the original (push the fork into it)? > > As far as I understood Emil, he aims for backwards > compatibility. However, the changes are invasive. There is very little > code left from the original script, if any at all. It is formally a > fork of the old repo, but for the reasons stated above, I would like > to keep the original repo around in place for a while (or, > alternatively, make Emil the maintainer of the original repo, see > original mail). >
Hi, @Skeen here. My original goal for the PR, and the following fork was indeed backwards compatibility. I created the PR with the goal of merging our in-house nagios plugin with the Prometheus one, as I though the resources spent on maintaining it, might as well be shared, and benefit multiple people. No reason to reinvent and remaintain the development of the wheel. I don't have a lot of input with regards to the status of the current repository, and whether it belongs in the Prometheus github organization, although it does seem a bit like a misfit. What I have a bit of input about, is my role as a potential future maintainer. The way I see it, I was gonna have to maintain this script in-house anyway, so the maintenance burden is one I already have. I do not feel strongly about whether it'll be maintained in the promtheus github organization, in the prometheus community, or where it already is. > -- > Björn Rabenstein > [PGP-ID] 0x851C3DA17D748D03 > [email] [email protected] <javascript:> > -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/5855ca15-639b-4754-be16-4a27e2b07fcc%40googlegroups.com.
