On 09 Mar 15:30, Brian Brazil wrote: > On Mon, 9 Mar 2020 at 15:26, Julien Pivotto <[email protected]> wrote: > > > Hi there, > > > > Sylvain has open a pull request to remove the vendor directory. We had > > larger threads before on versioning etc, but I would like to start a new > > thread about this particular topic to see if we have a consensus. > > > > https://github.com/prometheus/prometheus/pull/6949 > > > > One of the blocker I have is that I would like to be 100% sure that the > > checks that are run by CNCF on licence compatibility have full support > > for this, e.g. they can fetch the modules and scan the licenses. > > > > The question here is that as this is all internal, does this make sense for > our build&review processes?
Can you clarify the question. Are you speaking about removing vendoring or license check? > I don't recall offhand anyone in -team having issues with our current state > (beyond a brief discussion if we still wanted it when we switched to go-mod > - we do). I am all for keeping vendor but I have not really strong arguments against removing it. I often use it to grep some dependencies sources but I could still run go mod vendor locally. > > -- > Brian Brazil > www.robustperception.io -- (o- Julien Pivotto //\ Open-Source Consultant V_/_ Inuits - https://www.inuits.eu -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/20200309154120.GA365%40oxygen.
signature.asc
Description: PGP signature
