I don't see why not... Especially that we would have help and knowledge from you! (:
We would be actually super interested to see if GitLab would sponsor us some CI that would be stable for benchmarks cc @Krasimir Georgiev <[email protected]> Similar in Thanos... since GitLabe use Thanos (: In Thanos we tried to run our benchmarks on-demand/on each PR with GithubActions and failed miserably: https://github.com/thanos-io/thanos/pull/2233 Wonder if GitLab would have some more stable environment for our Prometheus Ecosystem projects to have more trust in what we merge. Bartek On Thu, 9 Apr 2020 at 09:23, Ben Kochie <[email protected]> wrote: > https://about.gitlab.com/solutions/github/ > > On Thu, Apr 9, 2020 at 10:05 AM Bartłomiej Płotka <[email protected]> > wrote: > >> Nice! I guess you cannot use GitLab CI while having repo on GitHub? 🤔 >> >> Bartek >> >> On Thu, 9 Apr 2020 at 08:50, Ben Kochie <[email protected]> wrote: >> >>> Something, something, gitlabci[0]. ;-) >>> >>> react-test: >>> only: >>> changes: >>> - web/ui/react-app/** >>> >>> [0]: https://docs.gitlab.com/ee/ci/yaml/#onlychangesexceptchanges >>> >>> On Thu, Apr 9, 2020 at 9:15 AM Bartłomiej Płotka <[email protected]> >>> wrote: >>> >>>> Yes, please! >>>> >>>> Also, we can think later on crafting some different matchers for which >>>> files should trigger which job! Thanks for proposing this (: >>>> >>>> Something simple like this >>>> https://discuss.circleci.com/t/how-to-run-a-job-or-a-step-only-when-a-specified-file-changed/29751 >>>> but >>>> some step that actually >>>> check what file has changed or something. >>>> >>>> Bartek >>>> >>>> On Thu, 9 Apr 2020 at 08:01, Ben Kochie <[email protected]> wrote: >>>> >>>>> Seems like a good idea to me. It can also run the tests in parallel. >>>>> >>>>> On Wed, Apr 8, 2020 at 11:23 PM Julien Pivotto <[email protected]> >>>>> wrote: >>>>> >>>>>> >>>>>> Hi there, >>>>>> >>>>>> What would you think of splitting React and Golang tests in 2 >>>>>> different >>>>>> circleci jobs? >>>>>> >>>>>> React is not predictable as we don't really pin dependencies, and a >>>>>> failure there implies that go tests don't run. >>>>>> >>>>>> -- >>>>>> (o- Julien Pivotto >>>>>> //\ Open-Source Consultant >>>>>> V_/_ Inuits - https://www.inuits.eu >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "Prometheus Developers" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to [email protected]. >>>>>> To view this discussion on the web visit >>>>>> https://groups.google.com/d/msgid/prometheus-developers/20200408212352.GA5655%40oxygen >>>>>> . >>>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Prometheus Developers" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/prometheus-developers/CABbyFmonc4n2R02t7N%2BO7tBuD6jOqdWUELEv6%3DShg7ZUHsCdXg%40mail.gmail.com >>>>> <https://groups.google.com/d/msgid/prometheus-developers/CABbyFmonc4n2R02t7N%2BO7tBuD6jOqdWUELEv6%3DShg7ZUHsCdXg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAMssQwag0ifAv1ixpc6-kbeDijobf5CyifsT7Gzgviq1%3DKnCvQ%40mail.gmail.com.
