OK. :) Following up there. On Sat, May 16, 2020 at 1:07 AM Brian Brazil < [email protected]> wrote:
> On Sat, 16 May 2020 at 04:59, Sally Lehman <[email protected]> wrote: > >> https://github.com/prometheus/cloudwatch_exporter/pull/225 is an >> existing pull to add debug logging to this repo that doesn't look like it >> has firm blockers for a merge. >> > > There are comments on the PR which the author has not addressed, thus it > is not ready for merge. > > >> It is functional, once merged with master, as I've done here >> https://github.com/rothsa/cloudwatch_exporter/tree/debug_logging >> >> FINEST: GetMetricStatisticsResult, works. It verifies that the metrics >> config part is loading, Great! From this I can tell that my config is >> loading, and I can see the current successful results of the scrape. This >> pull then, from my perspective is useful and helpful so far. >> >> >> The contributing page asks to get permission on this list first. I would >> like to add the following: >> >> >> 1. Logs to verify that the client has authenticated successfully, using >> role_arn like I expect it to. >> >> 2. Add to or modify GetMetricStatisticsRequest logs to give me additional >> data surrounding the datapoints response that indicates why all my >> ListMetrics calls return empty datapoint arrays as shown: >> >> ``` >> >> FINEST: GetMetricStatisticsRequest: {Namespace: AWS/ELB,MetricName: >> HealthyHostCount,Dimensions: [{Name: LoadBalancerName,Value: >> rothsa_lb}],StartTime: Sat May 16 02:36:23 UTC 2020,EndTime: Sat May 16 >> 02:46:23 UTC 2020,Period: 60,Statistics: [Sum, SampleCount, Minimum, >> Maximum, Average],ExtendedStatistics: [],} >> >> May 16, 2020 2:56:23 AM io.prometheus.cloudwatch.CloudWatchCollector >> scrape >> >> FINEST: GetMetricStatisticsResult[AWS/ELB/HealthyHostCount]: {Label: >> HealthyHostCount,Datapoints: []} >> >> ``` >> >> >> If I get a positive response here I will create a pull on >> https://github.com/prometheus/cloudwatch_exporter >> <https://github.com/prometheus/cloudwatch_exporter/pull/225> with the >> above contributions. >> > This is probably best discussed on a PR, as this is all repo-specific. > > Brian > > >> >> Thanks for all you do. :) >> >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Prometheus Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/prometheus-developers/115d3e68-4696-457c-8e41-8d2dcd6ab1b5%40googlegroups.com >> <https://groups.google.com/d/msgid/prometheus-developers/115d3e68-4696-457c-8e41-8d2dcd6ab1b5%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > > > -- > Brian Brazil > www.robustperception.io > -- Sally Lehman 503 703 3482 -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAEXD2EehDw93awYU36eiwzTBbwfgQW3-UhBqhXuCXbNXEBv3Ew%40mail.gmail.com.
