YES After reading the arguments, I agree that Kelvin / temperature is special enough to warrant an exception.
Overall I think it's good that we have rules like "base units only", but it's ok to have occasional exceptions if enough people think it's worth it. On Thu, May 28, 2020 at 8:52 PM Bjoern Rabenstein <[email protected]> wrote: > Dear Prometheans, > > So far, we have recommended Celsius as the base unit for temperatures, > despite Kelvin being the SI unit. That was well justified by the > overwhelming majority of use cases, where Kelvin would be just > weird. I'd really like to see more scientific usage of Prometheus, so > I was never super happy with that recommendation, but since it was > just a recommendation, I could live with it. > > Now Matt Layher came up with another, more technical use case: color > temperature. Here, using Celsius would be even weirder. So there is a > case where you clearly do not want to follow the suggestion of the > linter, which is more in line with typical Prometheus use cases than > my arguably somewhat far fetched time series for low-temperature > experiments. > > Therefore, Matt suggested to make the metrics linter not complain > about kelvin. > > I think this is a clearly defined problem with clear arguments and a > clear disagreement between Brian Brazil on the one side and Matt and > myself on the other side. The appropriate amount of effort has been > spent to find a consensus. All arguments can be found in > https://github.com/prometheus/client_golang/pull/761 and > https://github.com/prometheus/docs/pull/1648 . > > I hereby call a vote for the following proposal: > > Allow Kelvin as a base unit in certain cases and update our > documented recommendation and the linter code accordingly. > > > (The changes may take the form of the two PRs out there, but the vote > in about the general idea above, not the implementation detail.) > > > The vote closes on 2020-06-04 20:00 UTC. > -- > Björn Rabenstein > [PGP-ID] 0x851C3DA17D748D03 > [email] [email protected] > > -- > You received this message because you are subscribed to the Google Groups > "Prometheus Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/prometheus-developers/20200528185216.GK2326%40jahnn > . > -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6YowrQGJt9GVs8VCPdJTOL8MbuRjM4zzT5skD%3DVzBiKJnkg%40mail.gmail.com.
