On Fri, Sep 11, 2020 at 1:49 AM Brian Brazil <
[email protected]> wrote:

> On Thu, 10 Sep 2020 at 23:14, Julien Pivotto <[email protected]>
> wrote:
>
>> Hi,
>>
>> I'd like to add two new labels to prometheus/prometheus repository:
>>
>> "kind/new-sd"
>>     for new service discoveries requests
>>
>
> I think the existing service discovery label is sufficient, I'd rather not
> have overly granular definitions. For these issues it's
> generally obvious from the title what it is.
>

Titles are not good for label-based filtering. But I also think kind/new-sd
isn't right either. It's mixing "kind" and "component".

I would label a new service discovery with a pair of labels:
component/service-discovery + kind/feature


>
>
>> "bug scrub"
>>     for issues we want to have parsed at the bug scrubs. Not
>>     new ones, but old ones that have been somehow updated or that need to
>> be
>>     revisited.
>>
>
> How would this work? Bug scrubs are largely about going through issues
> that haven't been updated in a while, so if there's been a recent update
> then there's likely not to be much to do.
>
> Brian
>
>
>>
>> What do you think?
>>
>> Thanks!
>>
>> --
>> Julien Pivotto
>> @roidelapluie
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Prometheus Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to [email protected].
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/prometheus-developers/20200910221411.GA1303975%40oxygen
>> .
>>
>
>
> --
> Brian Brazil
> www.robustperception.io
>
> --
> You received this message because you are subscribed to the Google Groups
> "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/prometheus-developers/CAHJKeLonBdAedbAyMFDB3pmR0rQWyPZ1jKd9aYr9P1P_UH2buQ%40mail.gmail.com
> <https://groups.google.com/d/msgid/prometheus-developers/CAHJKeLonBdAedbAyMFDB3pmR0rQWyPZ1jKd9aYr9P1P_UH2buQ%40mail.gmail.com?utm_medium=email&utm_source=footer>
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/CABbyFmoq0Z0mJ0U%2BhPusk%2BRdr7zkacmxD0DkA8CuPPuRt%3DYkFg%40mail.gmail.com.

Reply via email to