Thank you both I will add that check to CI and then send a PR. On Friday, October 2, 2020 at 2:24:37 PM UTC+3:30 Julien Pivotto wrote:
> On 02 Oct 11:15, Brian Brazil wrote: > > On Fri, 2 Oct 2020 at 10:35, yzdann mohammadi <[email protected]> wrote: > > > > > Hi > > > I run `tox -e flake8` in the client_python master branch and got failed > > > tests. > > > I think it's a good idea to add pre-commit or even add linting as part > of > > > CI to this project to prevent this kind of issues > > > If it's helpful let me know and i will work on it. > > > > > > > Sure, send on a PR. > > > In general I think that CI is better than forcing people to run scripts > as part of pre-commit. > > > > > > Brian > > > > > > > > > > -- > > > You received this message because you are subscribed to the Google > Groups > > > "Prometheus Developers" group. > > > To unsubscribe from this group and stop receiving emails from it, send > an > > > email to [email protected]. > > > To view this discussion on the web visit > > > > https://groups.google.com/d/msgid/prometheus-developers/1302b4ca-394e-4781-a472-69acd6f59b90n%40googlegroups.com > > > < > https://groups.google.com/d/msgid/prometheus-developers/1302b4ca-394e-4781-a472-69acd6f59b90n%40googlegroups.com?utm_medium=email&utm_source=footer > > > > > . > > > > > > > > > -- > > Brian Brazil > > www.robustperception.io > > > > -- > > You received this message because you are subscribed to the Google > Groups "Prometheus Developers" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to [email protected]. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/prometheus-developers/CAHJKeLpV-AVmNduMKyGdOcvwxxxn47rJHQrEbdSsdf9G3t3SaQ%40mail.gmail.com > . > > -- > Julien Pivotto > @roidelapluie > -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/a9a7d561-3cb3-4a49-ad77-a47ca7fc0340n%40googlegroups.com.
