But it does rely on approval meaning "good to merge", rather than "only when someone else approves".
On 22 December 2020 16:28:18 GMT, Julien Pivotto <[email protected]> wrote: >So, to clarify, this is the equivalent to merge, just it wait for green >ci. > >Le mar. 22 déc. 2020 à 17:17, Julien Pivotto ><[email protected]> a >écrit : > >> Approve and auto merge are different. Auto merge is another value of >the >> merge button, next to squash etc. >> >> Le mar. 22 déc. 2020 à 16:59, Bjoern Rabenstein <[email protected]> >a >> écrit : >> >>> On 16.12.20 21:33, Julien Pivotto wrote: >>> > >>> > Can we enable the new github feature, auto-merge, in prometheus >>> > repositories? >>> > >>> > It waits for everything to be green before merging. >>> >>> Auto-merge assumes that all tests green and one valid approval means >>> "please merge". But I don't think that's true. I often approve a PR >to >>> express "looks good to me but others might still chime in". That >could >>> be the maintainer of the repo (or some other person specifically >>> qualified to review the PR). Those people should have the final >call. >>> >>> Or in other words: Having approval and merge as separate >>> human-initiated steps models the semantics just right, IMHO. >>> >>> -- >>> Björn Rabenstein >>> [PGP-ID] 0x851C3DA17D748D03 >>> [email] [email protected] >>> >>> -- >>> You received this message because you are subscribed to the Google >Groups >>> "Prometheus Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, >send an >>> email to [email protected]. >>> To view this discussion on the web visit >>> >https://groups.google.com/d/msgid/prometheus-developers/20201222155935.GL17627%40jahnn >>> . >>> >> > >-- >You received this message because you are subscribed to the Google >Groups "Prometheus Developers" group. >To unsubscribe from this group and stop receiving emails from it, send >an email to [email protected]. >To view this discussion on the web visit >https://groups.google.com/d/msgid/prometheus-developers/CAFJ6V0rJcO785RzuPsgPQBV7LhYoLnnYVAdNr4ZzBsM8zn1Udg%40mail.gmail.com. -- Sent from my Android device with K-9 Mail. Please excuse my brevity. -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CEB2EC96-27C3-4244-BB31-1D5F6EF40EDA%40Jahingo.com.
